Add warning/error handling for --include-external #1293
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidelGoogle
force-pushed
the
external_warnings
branch
from
465d439 to
b29f86f
Compare
kevmoo
reviewed
Dec 15, 2016
| List<Source> matchedSources = context.librarySources | ||
| .where((library) => matchesLibrary(includeExternal, library)); | ||
| if (matchedSources.isEmpty) { | ||
| print(" warning: $quotedArgString -- " + |
There was a problem hiding this comment.
FYI: + not needed here. adjacent String literals auto-concat. Is nice.
| for (String includeExternal in includeExternals) { | ||
| var quotedArgString = "'--include-external $includeExternal'"; | ||
| List<Source> matchedSources = context.librarySources | ||
| .where((library) => matchesLibrary(includeExternal, library)); |
There was a problem hiding this comment.
add .toList() here – make sure we don't re-iterate the iterable.
There was a problem hiding this comment.
What would it mean to re-iterate the iterable? Is this a general pattern we should have the analyzer warn about?
There was a problem hiding this comment.
Maybe. I should write-up a little dartpad thing to show this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes --include-external a bit harder to use incorrectly (with surprising results).
Cases I would like to test (but don't see an easy way how would include):
--external-library asldkfjsdfhit the "warn no libraries found" case--external-library darthit the "multiple libraries found" case--external-library dartdoc.darthit the "library already found" caseI looked at adding tests to test/dartdoc_test.dart, but those do not seem set up to handle logging. I looked briefly ad breaking this logic out into its own function, but it wasn't clear how to provide the necessary AnalysisContext with sources.
I've been able to trigger the first two test cases manually, but not yet seen the 3rd.